changes needed for encrypted assertions#31
Merged
steffow merged 8 commits intosteffow:developfrom Aug 14, 2018
Merged
Conversation
Author
|
Okay, we've testet this on our side. And we think it's good to go. What do you think? |
Owner
|
I’ll have look. I’m a bit busy at the moment, but will come back to you.
… On 7. Apr 2018, at 14:29, gerbsen ***@***.***> wrote:
Okay, we've testet this on our side. And we think it's good to go. What do you think?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub <#31 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGosJeF7nt27ej32nDXj7ZzzIOX0AzKbks5tmLEhgaJpZM4TDpi_>.
|
Author
|
Any chance yet to look at it? |
steffow
reviewed
Jul 9, 2018
| const encAssertion = response.getElementsByTagNameNS('urn:oasis:names:tc:SAML:2.0:assertion', 'EncryptedAssertion')[0]; | ||
|
|
||
| var xmlenc = require('xml-encryption'); | ||
| var options = { key: this.options.privateKey, }; |
Owner
There was a problem hiding this comment.
What are we doing after the comma?
added 2 commits
July 12, 2018 20:39
Removed useless private key
added encryption section
Author
|
Okay, I added a section for encryption now. Does that make sense? |
gerbsen
changed the title
Author
|
@steffow from our side this is done. okay to merge? |
steffow
approved these changes
Aug 14, 2018
steffow
approved these changes
Aug 14, 2018
Owner
|
Thanks. Published to Atmosphere. Thanks also for bearing w my time management ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, I just got the changes from @anicoa and I integrated them in a fresh
developbranch. Since it was a little bit difficult to actually merge since due to tabs/spaces/newlines etc. I would like to have @anicoa to have a look at it and give his go (he's the one who develop the fix). In the meantime you could check if this fits with your standards!