Bundle limitations and gotchas together in the README.md#73
Bundle limitations and gotchas together in the README.md#73stefanzweifel merged 8 commits intostefanzweifel:masterfrom spawnia:restructure-readme
Conversation
|
Is there any downside to always defining |
|
Thanks for this PR! 🙌
There is. |
It does not seem to error when trying to get its value, so the result is that you just get an empty string - which is what the current default is, if i am not mistaken. I actually just tried running it directly on a branch with |
|
Hm, seems this has changed since I tested this the last time. 😅 If this actually works, I think it would even make sense to use |
|
Using One downside: For Still thinking about if this would be a good approach. Would merge those PRs and update the README with an updated example, if I think we should go down that path. |
|
@stefanzweifel i simplified the README further and clarified the |
|
Just wanted to update the README too. Will do some last testing and then tag 4.2.0 |
|
@stefanzweifel feel free to edit my branch as needed or pick the parts you like :) |
The documentation of this action is really good and has a lot of information. We can make it easier to use by putting a common example first, then clearly listing the limitations and possible gotchas.
I found that there was a bit of duplication, so i attempted to consolidate and distill it down to the essentials.
Thank you for this package!