Skip to content

Remove unnecessary escape#57

Merged
stefanzweifel merged 1 commit intostefanzweifel:masterfrom
wxt2005:master
Apr 3, 2020
Merged

Remove unnecessary escape#57
stefanzweifel merged 1 commit intostefanzweifel:masterfrom
wxt2005:master

Conversation

@wxt2005
Copy link
Copy Markdown
Contributor

@wxt2005 wxt2005 commented Apr 3, 2020

GitHub Action will never actually set output result with the escaped quote, and ${{steps.<step_id>.outputs.changes_detected}} will always be null.

You could check the difference from the debug log between the current version and my fork.

Current Version
https://github.com/bangumi-data/bangumi-data/runs/557011365?check_suite_focus=true
image

Forked Version
https://github.com/bangumi-data/bangumi-data/runs/557156710?check_suite_focus=true
image

@stefanzweifel
Copy link
Copy Markdown
Owner

Thanks!

@stefanzweifel stefanzweifel merged commit 5573440 into stefanzweifel:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants