Add missing links in the CHANGELOG#223
Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom Jun 6, 2022
ericcornelissen:fix-changelog-links
Merged
Add missing links in the CHANGELOG#223stefanzweifel merged 2 commits intostefanzweifel:masterfrom ericcornelissen:fix-changelog-links
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
ericcornelissen:fix-changelog-links
Conversation
Add missing references to Pull Requests.
stefanzweifel
approved these changes
Jun 6, 2022
Owner
stefanzweifel
left a comment
stefanzweifel
left a comment
There was a problem hiding this comment.
Thank you very much Eric. 👏
I've updated our release-drafter config to link to PRs and authors directly in the future.
(Release notes are automatically put into the CHANGELOG)
I think adding links for all PR authors in the CHANGELOG is not really necessary. Links are also available in the pull requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing links for Pull Requests to the CHANGELOG. I considered adding links for the GitHub users as well, but opted not to as there's no precedence for that.
Also, I wasn't sure whether or not to include this change in the CHANGELOG. It doesn't seem necessary to me, but I'm happy to add it if that's preferred 🙂