String values in README.md extended example are now correct#196
Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom Sep 17, 2022
Merged
Conversation
Owner
stefanzweifel
left a comment
stefanzweifel
left a comment
There was a problem hiding this comment.
Thanks for your PR!
I'v added a comment regarding the changes to file_pattern.
As far as I know, one doesn't have to us quotes for strings in YAML. Except when one has special charcaters like : or # in them.
I personally like the "quote-less" style better and would like to keep it that way. Or did you run into issues with the current examples in the README? Any links where I could learn more about the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @stefanzweifel - great work on your GitHub Action. While playing with it, I realized that your example doesn't contain quotes to populate a string value for your action. This PR fixes that. Gruesse.