Fix checking out branch names with / chars#113
Merged
stefanzweifel merged 2 commits intostefanzweifel:masterfrom Oct 12, 2020
Merged
Fix checking out branch names with / chars#113stefanzweifel merged 2 commits intostefanzweifel:masterfrom
stefanzweifel merged 2 commits intostefanzweifel:masterfrom
Conversation
If git can't automatically figure out if the argument is a branch or
a path, it will need to be told explicitly by using `--`:
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'
Fixes: stefanzweifel#106
Contributor
Author
|
Here's a version of #106 that keeps using |
Owner
|
Thanks! |
Contributor
Author
|
Sorry about not updating the tests. I didn't realize you were mocking |
Owner
|
@docwhat No problem. Those tests are all really new (and a bit complicated). I don't expect contributors to update those. |
Contributor
Author
|
I would recommend not mocking That way you are testing the functionality of the code and can prevent regressions. |
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If git can't automatically figure out if the argument is a branch or
a path, it will need to be told explicitly by using
--:Fixes: #106