Repository navigation
Remove native dates support - #245
Merged
Merged
Conversation
ricardoboss
approved these changes
Sep 19, 2024
ricardoboss
left a comment
ricardoboss
left a comment
Collaborator
There was a problem hiding this comment.
Dart changes are good 👍
ricardoboss
requested changes
Sep 19, 2024
ricardoboss
approved these changes
Sep 19, 2024
baywet
approved these changes
Sep 19, 2024
Contributor
|
Thanks for taking this on. |
Collaborator
Author
|
Agreed @baywet ! Since we are at it, it would be great to have reviews from experts for the remaining languages (if it doesn't delay the release too much). An additional note on the fact that Kiota doesn't really need this release to fix any date/datetime handling in the abstraction layer. |
This was referenced Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #242
@baywet since you noticed that we should throw for unknown types, I noticed that in some implementation we have not been doing it and fixed this detail too.