Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR leaves two deprecation warnings in place:
The first proposes to
asyncSpawn closeWait(), which, in general sometimesasyncSpawnmight prove necessary or useful, but in general it can also lose track ofFutures and become the root cause of hard-to-trace crashes, so it seems useful to keep this as a compilation warning, pending more specific action.The second is effectively a false positive due to
nimbus-eth1/execution_chain/networking/eth1_enr.nim
Lines 17 to 18 in 1ec0006
which matches all of the
fromURIdefinitions, including the deprecated ones, even thoughnimbus-eth1doesn't actually use the deprecated ones. I'm not sure I'd defend calling that a Nim bug; it seems to be a correct warning.To resolve that: