Merged
Conversation
why This allows to complete syncer initialisation for particular tasks, for test purposes as well as potential production run-time extensions.
why Only used for particular debugging tests. It has to be enabled by setting a constant in the `nimbus_config` (rather than a command line option.) The ticker or a similar functionality can be set up differently, not affecting the production binary.
why Only used for particular debugging tests. These test can be set up differently, not affecting the production binary.
arnetheduck
reviewed
Sep 4, 2025
mjfh
added a commit
that referenced
this pull request
Sep 5, 2025
* Re-implement the config hook inside the `BeaconSyncRef` descriptor why The implementation on PR #3619 relied on a global variable to be set before the constructor was called. This not gc-safe in general (see remarks on PR #3619.) * Remove `shouldRun()` from syncer why The decision whether running the syncer will have any effect at all should be made only within the function that sets up the syncer. There is no need for an external register (i.e. `ctx.shouldRun`.) * Fix header records list `metrics` race condition why By using list manipulation functions directly (e.g. ctx.hdr.staged.clear() without updating `metrics`) there were odd metrics states displayed. The `header` module now always uses wrappers for changing the header records list. These wrappers update the `metrics` variable accordingly. * Fix potential block records list `metrics` race condition why The `block` module now always uses wrappers for changing the block records list. These wrappers update the `metrics` variable accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.