Merged
Conversation
The current VertexRef is a composition of two case object types - this layout is inefficient in that each VertexRef instance takes up as much memory as its largest member. Adding to the insult are the two case fields which each take up space. Here, we use inhertance instead to create optimally sized verticies for each node kind - in particular, the Brach kind kan drop the prefix and reduce its memory usage to a fraction of what it was using before. The memory savings are instead invested in a larger key cache - when processing blocks for live syncing, key lookups are the source of a significant majority (95%) of database reads - when importing, the key cache is simply allotted to verticies instead.
The current VertexRef is a composition of two case object types - this layout is inefficient in that each VertexRef instance takes up as much memory as its largest member. Adding to the insult are the two case fields which each take up space. Here, we use inhertance instead to create optimally sized verticies for each node kind - in particular, the Brach kind kan drop the prefix and reduce its memory usage to a fraction of what it was using before. The memory savings are instead invested in a larger key cache - when processing blocks for live syncing, key lookups are the source of a significant majority (95%) of database reads - when importing, the key cache is simply allotted to verticies instead.
tersec
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current VertexRef is a composition of two case object types - this layout is inefficient in that each VertexRef instance takes up as much memory as its largest member. Adding to the insult are the two case fields which each take up space.
Here, we use inhertance instead to create optimally sized verticies for each node kind - in particular, the Brach kind kan drop the prefix and reduce its memory usage to a fraction of what it was using before.
The memory savings are instead invested in a larger key cache - when processing blocks for live syncing, key lookups are the source of a significant majority (95%) of database reads - when importing, the key cache is simply allotted to verticies instead.