proxy: fix [XDeclaredButNotUsed] for verified proxy code (#3538)

chirag-parmar · web-flow · commit e9646ea3a514 · 2025-08-04T11:30:37.000Z
* fix

* more fix
diff --git a/execution_chain/version.nim b/execution_chain/version.nim
@@ -13,7 +13,7 @@ import
   stew/byteutils, ./compile_info
 
 const
-  sourcePath  = currentSourcePath.rsplit({DirSep, AltSep}, 1)[0]
+  sourcePath = currentSourcePath.rsplit({DirSep, AltSep}, 1)[0]
   nimbusRevision {.strdefine.} = "00000000"
 
 static:
diff --git a/nimbus_verified_proxy/header_store.nim b/nimbus_verified_proxy/header_store.nim
@@ -28,32 +28,32 @@ type HeaderStore* = ref object
 
 func convLCHeader*(lcHeader: ForkedLightClientHeader): Result[Header, string] =
   withForkyHeader(lcHeader):
-    template p(): auto =
-      forkyHeader.execution
+    when lcDataFork > LightClientDataFork.Altair:
+      template p(): auto =
+        forkyHeader.execution
 
-    when lcDataFork >= LightClientDataFork.Capella:
-      let withdrawalsRoot = Opt.some(p.withdrawals_root.asBlockHash)
-    else:
-      const withdrawalsRoot = Opt.none(Hash32)
+      when lcDataFork >= LightClientDataFork.Capella:
+        let withdrawalsRoot = Opt.some(p.withdrawals_root.asBlockHash)
+      else:
+        const withdrawalsRoot = Opt.none(Hash32)
 
-    when lcDataFork >= LightClientDataFork.Deneb:
-      let
-        blobGasUsed = Opt.some(p.blob_gas_used)
-        excessBlobGas = Opt.some(p.excess_blob_gas)
-        parentBeaconBlockRoot = Opt.some(forkyHeader.beacon.parent_root.asBlockHash)
-    else:
-      const
-        blobGasUsed = Opt.none(uint64)
-        excessBlobGas = Opt.none(uint64)
-        parentBeaconBlockRoot = Opt.none(Hash32)
-
-    when lcDataFork >= LightClientDataFork.Electra:
-      # INFO: there is no visibility of the execution requests hash in light client header
-      let requestsHash = Opt.none(Hash32)
-    else:
-      const requestsHash = Opt.none(Hash32)
+      when lcDataFork >= LightClientDataFork.Deneb:
+        let
+          blobGasUsed = Opt.some(p.blob_gas_used)
+          excessBlobGas = Opt.some(p.excess_blob_gas)
+          parentBeaconBlockRoot = Opt.some(forkyHeader.beacon.parent_root.asBlockHash)
+      else:
+        const
+          blobGasUsed = Opt.none(uint64)
+          excessBlobGas = Opt.none(uint64)
+          parentBeaconBlockRoot = Opt.none(Hash32)
+
+      when lcDataFork >= LightClientDataFork.Electra:
+        # INFO: there is no visibility of the execution requests hash in light client header
+        let requestsHash = Opt.none(Hash32)
+      else:
+        const requestsHash = Opt.none(Hash32)
 
-    when lcDataFork > LightClientDataFork.Altair:
       let h = Header(
         parentHash: p.parent_hash.asBlockHash,
         ommersHash: EMPTY_UNCLE_HASH,
@@ -77,6 +77,7 @@ func convLCHeader*(lcHeader: ForkedLightClientHeader): Result[Header, string] =
         parentBeaconBlockRoot: parentBeaconBlockRoot,
         requestsHash: requestsHash,
       )
+
       return ok(h)
     else:
       # running verified  proxy for altair doesn't make sense
diff --git a/nimbus_verified_proxy/rpc/evm.nim b/nimbus_verified_proxy/rpc/evm.nim
@@ -28,7 +28,7 @@ proc toAsyncEvmStateBackend*(vp: VerifiedRpcProxy): AsyncEvmStateBackend =
       let account =
         try:
           (await vp.getAccount(address, header.number, header.stateRoot))
-        except CatchableError as e:
+        except CatchableError:
           error "error getting account"
           return Opt.none(Account)
 
@@ -43,7 +43,7 @@ proc toAsyncEvmStateBackend*(vp: VerifiedRpcProxy): AsyncEvmStateBackend =
       let storageSlot =
         try:
           (await vp.getStorageAt(address, slotKey, header.number, header.stateRoot))
-        except CatchableError as e:
+        except CatchableError:
           error "error getting storage"
           return Opt.none(UInt256)
 
@@ -58,7 +58,7 @@ proc toAsyncEvmStateBackend*(vp: VerifiedRpcProxy): AsyncEvmStateBackend =
       let code =
         try:
           (await vp.getCode(address, header.number, header.stateRoot))
-        except CatchableError as e:
+        except CatchableError:
           error "error getting code"
           return Opt.none(seq[byte])
 
