Skip to content

Backport of #9270: add Pyodide support and CI jobs for v0.14.x#9365

Merged
bashtage merged 13 commits intostatsmodels:maintenance/0.14.xfrom
agriyakhetarpal:backport/pyodide-support
Sep 17, 2024
Merged

Backport of #9270: add Pyodide support and CI jobs for v0.14.x#9365
bashtage merged 13 commits intostatsmodels:maintenance/0.14.xfrom
agriyakhetarpal:backport/pyodide-support

Conversation

@agriyakhetarpal
Copy link
Contributor

@agriyakhetarpal agriyakhetarpal commented Sep 16, 2024

  • closes #xxxx
  • tests added / passed.
  • code/documentation is well formatted.
  • properly formatted commit message. See
    NumPy's guide.

This PR has been stemmed off from #9166 (comment). It is a backport of #9270 to the 0.14.x branch – the PR originally added Pyodide support and testing improvements through a CI job.

Details

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@agriyakhetarpal agriyakhetarpal marked this pull request as draft September 16, 2024 15:07
@pep8speaks
Copy link

pep8speaks commented Sep 16, 2024

Hello @agriyakhetarpal! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-16 15:45:39 UTC

@agriyakhetarpal agriyakhetarpal marked this pull request as ready for review September 16, 2024 15:34
@agriyakhetarpal agriyakhetarpal changed the title Backport of #9270: add Pyodide support and CI jobs for v0.14.X Backport of #9270: add Pyodide support and CI jobs for v0.14.x Sep 16, 2024
@agriyakhetarpal
Copy link
Contributor Author

All tests are passing, I'll remove the workflow trigger.

@bashtage
Copy link
Member

Thanks.

@bashtage bashtage merged commit 843e94d into statsmodels:maintenance/0.14.x Sep 17, 2024
@agriyakhetarpal agriyakhetarpal deleted the backport/pyodide-support branch September 17, 2024 08:48
@agriyakhetarpal
Copy link
Contributor Author

@bashtage, you mentioned a while earlier that a 0.14.4 release can be made with this change. Please let me know if you still have it in the ambit; I'm happy to help—where I can—with any other issues or PRs that might be needed for getting into a release.

@bashtage
Copy link
Member

bashtage commented Oct 3, 2024

@agriyakhetarpal
Copy link
Contributor Author

Superb, thank you again for all the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants