You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Bug fix: filter out nans in npc combining functions #226
Currently the fisher and other combining functions do not filter out nan pvalues, which results in the function returning nan if a single p value is nan
P-values should be in [0, 1] and never NaN, so I think the default behavior of combining functions should be to throw an error if there are NaNs, with a flag to either ignore silently or ignore and warn if there are NaNs among the P-values.
Activity
pbstark commentedon Nov 11, 2025
P-values should be in [0, 1] and never NaN, so I think the default behavior of combining functions should be to throw an error if there are NaNs, with a flag to either ignore silently or ignore and warn if there are NaNs among the P-values.