Skip to content

Simplify default public directory for Docker image and improve default error pages #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joseluisq merged 2 commits into from
Nov 15, 2025
Merged

Simplify default public directory for Docker image and improve default error pages #579

joseluisq merged 2 commits into from
Nov 15, 2025

Conversation

@joseluisq
Copy link
Collaborator

@joseluisq joseluisq commented Nov 15, 2025 •
edited
Loading

Description

This PR simplifies the docker/public files delivered via the Docker images (just one index.html file) and improves default error pages by correcting HTML content and styles (viewport and color-scheme).

Additionally, update all tests using that directory.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@joseluisq joseluisq self-assigned this Nov 15, 2025
@joseluisq joseluisq added enhancement New feature or request docker Related to Docker environment or images labels Nov 15, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 15, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  tests/rewrites.rs  66% smaller
  docker/public/index.html  31% smaller
  src/error_page.rs  21% smaller
  tests/dir_listing.rs  11% smaller
  tests/static_files.rs  2% smaller
  Cargo.toml Unsupported file format
  docker/public/assets/favicon.ico Unsupported file format
  tests/cors.rs  0% smaller
  tests/fixtures/public/404.html  0% smaller
  tests/fixtures/public/50x.html  0% smaller
  tests/fixtures/public/assets/index.html  0% smaller
  tests/fixtures/public/assets/main.css  0% smaller
  tests/fixtures/public/assets/main.js  0% smaller
  tests/fixtures/toml/rewrites.toml Unsupported file format
  tests/handler.rs  0% smaller

@joseluisq joseluisq force-pushed the simplify-default-public-dir branch from 4086175 to 3b9e28c Compare November 15, 2025 20:43
@joseluisq joseluisq merged commit d48da4c into master Nov 15, 2025
2 checks passed
@joseluisq joseluisq deleted the simplify-default-public-dir branch November 15, 2025 20:48
@joseluisq joseluisq added this to the v2.40.0 milestone Nov 20, 2025
@joseluisq joseluisq added the v2 v2 release label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@joseluisq joseluisq

Labels

docker Related to Docker environment or images enhancement New feature or request v2 v2 release

Projects

None yet

Milestone

v2.40.0

Development

Successfully merging this pull request may close these issues.

2 participants

@joseluisq