Virtual Hosts: support HTTP/2 using :authority #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, the HTTP host header has been used to determine the hostname that is being accessed. In HTTP/2, this header is not guaranteed to be sent. Instead, the ":authority" pseudo-header field is used. This commit adds a check for that header to make virtual hosts also work with HTTP/2. Additionally, this commit adds code to check and remove the port number, which may or may not be sent as part of the HTTP host header.
|
Review changes with |
joseluisq
commented
Oct 18, 2025
Comment on lines
+21
to
+23
| if vhosts.is_empty() { | ||
| return None; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
FYI, new lines added.
joseluisq
commented
Oct 18, 2025
| } | ||
|
|
||
| #[cfg(test)] | ||
| mod tests { |
Collaborator
Author
There was a problem hiding this comment.
FYI, some tests were added too.
Collaborator
Author
|
@CrazyCraftix PR merged and is ready for the next release. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It resolves #569 and supersedes the previous one #570 by @CrazyCraftix accidentally closed.
Description
So far, the HTTP host header has been used to determine the hostname that is being accessed. In HTTP/2, this header is not guaranteed to be sent. Instead, the ":authority" pseudo-header field is used. I added a check for that header to make virtual hosts also work with HTTP/2.
Also I found out that the HTTP host header may also contain the port number, so I added a check to remove it if it's there.
How Has This Been Tested?
Not thoroughly, just manually for my usecase, so there may still be problems I didn't consider.I suppose an automated test would be nice but I'm not sure what's the best way to do this.See unit tests added.