Optimize Tag List Page Performance#6398
Merged
WithoutPants merged 1 commit intostashapp:developfrom Dec 11, 2025
Merged
Conversation
Collaborator
Author
|
Did a bit more testing with this change on my DB. The result is so much better. I've moved the PR out of Draft. |
WithoutPants
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Problem:
The tag list page was slow to load because for every tag displayed, the TagData fragment requested 14 count fields:
The recursive *_count_all fields use expensive recursive common table expressions to traverse the tag hierarchy and count all descendants. With 9M+ rows in my scenes_tags, this was extremely slow.
The *_count_all fields were fetched but never displayed on the list page - they're only used on the tag detail page.
Solution:
Created a new TagListData fragment and FindTagsForList query that only fetches the direct counts needed for the list page display.