Skip to content

Comments

Respect user preference for type-to-create in image/scene multi-select form#6376

Merged
WithoutPants merged 5 commits intodevelopfrom
unknown repository
Dec 10, 2025
Merged

Respect user preference for type-to-create in image/scene multi-select form#6376
WithoutPants merged 5 commits intodevelopfrom
unknown repository

Conversation

@ghost
Copy link

@ghost ghost commented Dec 4, 2025

When selecting multiple images, you were previously unable to create new galleries from the edit images form itself. This PR adds the functionality, and corresponding disable behavior.

Dropdown Configuration
Create Gallery from Dropdown Settings Option

To be transparent, I am new to much of the tech stack in this repository, so I implemented this PR with some help from Claude Opus 4.5. If anything seems off, I'm happy to investigate and learn why. I would like to help enhance image-related features in the future, as it's my primary use case.

I get some linter errors when I validate, but I tested develop HEAD and get the same thing, so I'm ignoring.
image

@ghost
Copy link
Author

ghost commented Dec 4, 2025

I slightly misunderstood the codegen and was adding a redundant resolver, but I've cleaned it up now.

@ghost
Copy link
Author

ghost commented Dec 6, 2025

I'm not sure how I didn't catch this before, but it's pretty no-brainer to enable this for performers and tags at the same time. I'll update this PR with that soon

@ghost ghost changed the title Allow creation of galleries from multi-select form Respect user preference for type-to-create in image/scene multi-select form Dec 7, 2025
@ghost
Copy link
Author

ghost commented Dec 7, 2025

I noticed the other fields in scene/image multi-select don't respect the type-to-create config setting, and traced it back to Select.tsx explicitly setting the createable prop to false. I went ahead and removed this default prop, so it uses whatever the user has in their config for the behavior for all of these settings.

I don't think this interferes with anything else in the codebase, but let me know.

image

@ghost
Copy link
Author

ghost commented Dec 7, 2025

This should be ready for review now.

  1. Adds boilerplate to allow "Galleries" dropdown to be creatable
  2. Removes forcing dropdowns in Select.tsx to not be creatable

@feederbox826
Copy link
Collaborator

I get some linter errors when I validate, but I tested develop HEAD and get the same thing, so I'm ignoring.

pnpm install

@WithoutPants WithoutPants added this to the Version 0.30.0 milestone Dec 8, 2025
@WithoutPants WithoutPants added the improvement Something needed tweaking. label Dec 8, 2025
@ghost
Copy link
Author

ghost commented Dec 9, 2025

I decided to retain the base case, but just added a switch with the existing selection components to return versions where the props would populate creatable from the configuration. Thoughts?

@WithoutPants WithoutPants merged commit a4816b4 into stashapp:develop Dec 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Something needed tweaking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants