Merged
Conversation
prevents screen from sleeping ONLY in secure contexts (localhost, https) closes stashapp#2884
Contributor
|
I would probably mention in the description that this is specifically while a video is playing |
Collaborator
Author
|
yes, needs testing please. I couldn't get android, iOS or W11 to timeout and blank out the screen, I'm assuming they have some hooks into background media playback |
|
This pull request has been mentioned on Stash. There might be relevant details there: |
Collaborator
Author
|
I think I got this validated by just leaving a scene playing for ~45mins and my phone not locking |
release wakelock on dispose and end, call out secure contexts in error message
WithoutPants
approved these changes
Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prevents screen from sleeping ONLY in secure contexts (localhost, https) while videos are playing and in focus
closes #2884