Bugfix: Update Markers to % Base Calc#6323
Merged
WithoutPants merged 2 commits intostashapp:developfrom Nov 27, 2025
Merged
Conversation
Contributor
|
Why not use min-width for the 8px min width, to slightly simplify the calc expression? |
Collaborator
Author
|
Because I am a complicated person who hates CSS lol. You are not wrong tho, can change it over. |
WithoutPants
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes range markers (markers with end times) displaying at incorrect positions in fullscreen mode. The issue was that range markers used fixed pixel positioning calculated at render time, which didn't scale when the player resized. Changed to percentage-based calc() positioning to match how dot markers work. Added in a bunch of comments so I could track my math lol.
Tested on my Mac with Waterfox:
Created a marker at 1sec-10minutes. Pre fix there was an offset due to the bug. After the fix the marker was in the expected location when going fullscreen.
Fixes #6286