Bugfix: Tagger Ignoing Disambiguation When Linking Performer#6308
Merged
WithoutPants merged 3 commits intostashapp:developfrom Nov 26, 2025
Merged
Bugfix: Tagger Ignoing Disambiguation When Linking Performer#6308WithoutPants merged 3 commits intostashapp:developfrom
WithoutPants merged 3 commits intostashapp:developfrom
Conversation
Gykes
added
backend
Collaborator
|
Reminder for myself: test non-stash-box source. |
Collaborator
Author
|
So, I actually thought about this last night as I went to bed. I don't think non stashbox sources will return a remote ID so I will probably change it up so that if one exists use that if not revert to name |
Comment on lines
673
to
678
| // Match by remote_site_id if available, otherwise fall back to name | ||
| const matches = performer.remote_site_id | ||
| ? p.remote_site_id === performer.remote_site_id | ||
| : p.name === performer.name; | ||
|
|
||
| if (matches) { |
Collaborator
There was a problem hiding this comment.
performer.remote_site_id is known to be defined at the top of this function. This change won't be necessary.
Collaborator
Author
There was a problem hiding this comment.
Removed this from performer link. I haven't been able to do much testing on this as it's hard for me to reproduce.
WithoutPants
approved these changes
Nov 26, 2025
Collaborator
WithoutPants
left a comment
WithoutPants
left a comment
There was a problem hiding this comment.
Tested with stash-box source, and I'm satisfied that it will work for non-stash-box sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the performer matching logic in
createNewPerformerto useremote_site_idinstead of name when updating search results. This ensures only the specific performer being created gets updated with the newstored_id, preventing the previous performer from being unmatched between performers with matching namesFixes: #6038