Manually Search Stash ID - Edit Page - Performers#6284
Manually Search Stash ID - Edit Page - Performers#6284WithoutPants merged 12 commits intostashapp:developfrom
Conversation
|
I think In the modal dialog, I think a simple select would be better than a Text field in the modal dialog needs to be made consistent with other text fields. I wasn't able to actually set a value with this. I could get search results, but clicking on it didn't do anything. |
|
I put that verbage due to the button being there but it's not super obvious what the button is for. We can make it to where the "StashID:" always appears then it makes a little more sense than a random button that just says "Add" or something along those lines. For the simple select how do you mean? I know I have roughly 4 Stashboxes and just listing them out would take up quite a lot of space. I will look at the setting the value. I was able to se it last night just fine we maybe I broke something in my latest commit. |
WithoutPants
left a comment
WithoutPants
left a comment
There was a problem hiding this comment.
Result list styling needs fixing:
cursor: pointer should also be added to the seach result items to indicate that they are clickable.
There is a peculiar usability issue that probably needs addressing as well. Adding an id where the performer already has one from the same stash-box instance replaces it: which is expected, but is a weird UX experience; there's no obvious indication that the existing stash id was replaced unless you're looking at the ids. I think the solution here is a warning that should appear when a stash-box instance is selected for which there is already one, OR a dialog should pop up after the id is selected to confirm the replace operation.
ui/v2.5/src/components/Performers/PerformerDetails/PerformerEditPanel.tsx
Show resolved
Hide resolved
ui/v2.5/src/components/Performers/PerformerDetails/PerformerEditPanel.tsx
Outdated
Show resolved
Hide resolved
ui/v2.5/src/components/Performers/PerformerDetails/PerformerEditPanel.tsx
Show resolved
Hide resolved
|
Lots of changes that you request. One thing I did was remove the style on the list so that there were no more bullets. |
WithoutPants
changed the title
DogmaDragon
changed the title
2 participants
This allows users to manually search for Stash IDs inside of the performer modal via name or stash ID. I built the Search Modal out more than needed to support the other sections later on but it still needs work to include tags. Once we get performers locked down then I can go ahead and move it over for the rest of the required edit pages
Screenshots: #6271 (comment)