Bugfix: Fix empty Aliases Being Created for Studios#6273
Bugfix: Fix empty Aliases Being Created for Studios#6273WithoutPants merged 6 commits intostashapp:developfrom
Conversation
Filter out empty strings when processing studio aliases to prevent empty aliases from being saved. Fixes issue where empty aliases block studio creation/updates with 'Alias '' is in use' error. Fixes stashapp#6272
|
Managed to test this really quick. Followed the steps in the original issue and received no errors. My Steps: |
This was calling using the values which are not necessarily the final values.
WithoutPants
left a comment
WithoutPants
left a comment
There was a problem hiding this comment.
I changed the backend code to reject empty aliases (I've left out the trim space stuff in preference of the changes in #6226), instead of silently filtering them out.
I removed an existing invalid call to validate the aliases in the studio code update partial code, which would validate the values regardless of set mode.
Front end code looks good.
feederbox826
left a comment
feederbox826
left a comment
There was a problem hiding this comment.
fixes the bug, doesnt past lint 👀
3 participants
Fix empty aliases being created for studios. Filter out empty strings when processing studio aliases to prevent empty aliases from being saved. Fixes issue where empty aliases block studio creation/updates with 'Alias '' is in use' error.
This is untested. Will test in a few hours.
Fixes #6272