Feature: Support inputURL and inputHostname in scrapers#6250
Feature: Support inputURL and inputHostname in scrapers#6250WithoutPants merged 3 commits intostashapp:developfrom
Conversation
DogmaDragon
left a comment
There was a problem hiding this comment.
Documentation check passed.
|
Was this less work than the scraping system? probably infinitely. Was it fun making the most obscure hacky workarounds for missing URL? yes. |
|
If there would be a better way to do this as far as usability goes please let me know. I don't use scrapers so not sure if this is a painful or painless implementation. |
Ah yes, I remember first seeing @Maista6969 |
Adding hostname as well as URL would be great, we wouldn't need to parse it out manually |
Shouldn't be an issue. I can add it in here or if @WithoutPants wants it in a separate PR I can do that. |
|
Adding to this PR is fine. |
This PR adds a
{inputURL}placeholder that can be used in both fixed values and selector expressions within YAML scraper configurations. The placeholder is automatically replaced with the actual URL that was used to perform the scrape.Implementation Details
I havent officially tested this as I had so many GH issues. Will do it tomorrow or someone else can test.
Fixes: #4087