Skip to content

Comments

Remember the selected stash box in scene tagger#6192

Merged
WithoutPants merged 3 commits intostashapp:developfrom
smith113-p:savestashbox
Nov 6, 2025
Merged

Remember the selected stash box in scene tagger#6192
WithoutPants merged 3 commits intostashapp:developfrom
smith113-p:savestashbox

Conversation

@smith113-p
Copy link
Contributor

This stores the selected stash box in the config, the same way that studio and performer tagger do (it uses the same setting).

If a non-stashbox source (scraper) is selected, this is not remembered.

I have removed the currentSource dependency because there is no need to
re-run this code when the selected source changes and it caused issues
during testing at one point.

Resolves #6191

This stores the selected stash box in the config, the same way that
studio and performer tagger do (it uses the same setting).

If a non-stashbox source (scraper) is selected, this is not remembered.

Resolves stashapp#6191
@smith113-p
Copy link
Contributor Author

argh, if I re-add currentSource like lint wants me to, then if I change the stash box in the dropdown, it keeps toggling between the previous and the new stashbox in an infinite loop :(

@smith113-p
Copy link
Contributor Author

OK, figured out how to fix lint without causing that issue

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Oct 28, 2025
@WithoutPants WithoutPants added this to the Version 0.30.0 milestone Oct 28, 2025
@WithoutPants WithoutPants merged commit d831e45 into stashapp:develop Nov 6, 2025
2 checks passed
@smith113-p smith113-p deleted the savestashbox branch November 6, 2025 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Something needed tweaking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scene tagger should remember selected source

2 participants