Skip to content

Comments

Add timeout to ffmpeg hardware tests#6154

Merged
WithoutPants merged 1 commit intostashapp:developfrom
WithoutPants:issues/6064
Oct 20, 2025
Merged

Add timeout to ffmpeg hardware tests#6154
WithoutPants merged 1 commit intostashapp:developfrom
WithoutPants:issues/6064

Conversation

@WithoutPants
Copy link
Collaborator

Resolves #6064

Defaults timeout to 1 second which should be fine for most tests and systems. The timeout can be overridden by setting the STASH_HW_TEST_TIMEOUT environment variable in seconds.

@WithoutPants WithoutPants added the bug Something isn't working label Oct 19, 2025
@feederbox826
Copy link
Collaborator

feederbox826 commented Oct 20, 2025

Unable to replicate on v0.28.1, or latest_develop, could have been update to one of many components in the middle

I think the test is still appreciated since it does obey TERM and KILL and docker systems without hwaccel support can early exit

@feederbox826
Copy link
Collaborator

For the record, running the same commands now yields (correctly) Generic error in an external library so I believe it was an upstream dependency

@WithoutPants WithoutPants added this to the Version 0.29.0 milestone Oct 20, 2025
@WithoutPants WithoutPants merged commit c162c38 into stashapp:develop Oct 20, 2025
2 checks passed
XGFan pushed a commit to XGFan/stash that referenced this pull request Oct 22, 2025
@planetrocky
Copy link

Isn't there a config.yml setting for this? It would be more convenient than having a pre-loader script set an Environment variable.

@WithoutPants
Copy link
Collaborator Author

Having it in the config file is a bit overkill for the purpose. This was mainly to avoid the application hanging, so let's just bump up the default. What value is working for you?

@discourse-stashapp
Copy link

This pull request has been mentioned on Stash. There might be relevant details there:

https://discourse.stashapp.cc/t/windows-system-tray-v0-30-0/4812/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug Report] QSV hwaccel on ffmpeg v8 is broken

4 participants