Update marker background color logic to use primaryTag name instead of title#6141
Merged
WithoutPants merged 2 commits intostashapp:developfrom Oct 20, 2025
Merged
Update marker background color logic to use primaryTag name instead of title#6141WithoutPants merged 2 commits intostashapp:developfrom
WithoutPants merged 2 commits intostashapp:developfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
theqwertyqwert
force-pushed
the
develop
branch
from
ac1985e to
046d885
Compare
WithoutPants
approved these changes
Oct 20, 2025
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently marker colors are generated based on unique primary tags in
ScenePlayer.tsx, but then the colors are fetched based on the title. this changesmarkers.tsto get the color by primary tag