Skip to content

Comments

Edit filter load save#6092

Merged
WithoutPants merged 7 commits intostashapp:developfrom
WithoutPants:edit-filter-load-save
Sep 18, 2025
Merged

Edit filter load save#6092
WithoutPants merged 7 commits intostashapp:developfrom
WithoutPants:edit-filter-load-save

Conversation

@WithoutPants
Copy link
Collaborator

Related Discourse post: https://discourse.stashapp.cc/t/query-page-redesign/2064/79?u=withoutpants

Adds Load... and Save... buttons to the Edit Filter dialog:

image

This provides a definitive and context-appropriate location for these functions. The new scene list design puts these functions into the sidebar, which may not necessarily be visible in all viewports.

Clicking the save button opens the same dialog as clicking Save Filter on the sidebar:

image

Clicking the load button opens a similar dialog to load a filter:

image

@WithoutPants WithoutPants added this to the Version 0.29.0 milestone Sep 17, 2025
@WithoutPants WithoutPants added improvement Something needed tweaking. ui Issues related to UI labels Sep 17, 2025
Copy link
Collaborator

@cj12312021 cj12312021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the Load filter and Save filter functionality primarily across the scenes and groups pages, and performed quick sniff tests on the rest of the pages, ensuring the Edit Filter menu loads and is visually consistent.

Functionality, everything appears to be working just fine. Visually, it's odd that the “Load filter” and “Save filter” text will always overflow, only rendering as “Load...” and “Save...”. If we are okay with this, it would be worth adding the title property to those buttons so the full text is readable on hover.

@WithoutPants
Copy link
Collaborator Author

Thanks for testing :)

Functionality, everything appears to be working just fine. Visually, it's odd that the “Load filter” and “Save filter” text will always overflow, only rendering as “Load...” and “Save...”. If we are okay with this, it would be worth adding the title property to those buttons so the full text is readable on hover.

Load... and Save... use ellipses to indicate that another dialog will load, rather than performing an action. I chose not to include filter for brevity. Adding a title for clarity should be fine though.

@WithoutPants WithoutPants merged commit 793a5f8 into stashapp:develop Sep 18, 2025
2 checks passed
XGFan pushed a commit to XGFan/stash that referenced this pull request Oct 22, 2025
* Add load/save buttons to edit filter dialog
* Add title to save filter dialog
* Change ExistingSavedFilterList parameters
* Add title to load/save buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Something needed tweaking. ui Issues related to UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants