Treat images with no exif metadata as well-oriented#6006
Merged
WithoutPants merged 1 commit intostashapp:developfrom Sep 9, 2025
Merged
Conversation
Contributor
Author
|
Related to the same problem with ImageWall that led me to dig in to #4781 |
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some images fail to be loaded by
goexif, but the error raised is notEOF-- it's a hard-coded "failed to find exif intro marker". In turn, the images are falsely assigned width and height of 0, and this causes theImageWallview to fail thegetCommonHeighthelper returning NaN. In turn, this leaves all images on anyImageWallincluding at least one bad-EXIF image with width and height ofNaN.