fix: Prevent generating invalid link on empty scraper response#5876
Merged
WithoutPants merged 1 commit intostashapp:developfrom Jun 11, 2025
Larsluph:fix/scraper-link
Merged
fix: Prevent generating invalid link on empty scraper response#5876WithoutPants merged 1 commit intostashapp:developfrom Larsluph:fix/scraper-link
WithoutPants merged 1 commit intostashapp:developfrom
Larsluph:fix/scraper-link
Conversation
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old behaviour
When using a scraper that doesn't return an ID for studios or performers, the current version of stash generates an invalid link due to unsafe string building.
URL generated:
https://${STASH_BASE_URL}/undefinednullFixed behaviour
A check has been added that prevents generating such links and keeping it a bolded text element instead.