Merged
Conversation
WithoutPants
added
bug
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
* Improve error messages when unable to contact server * Improve error message presentation * Catch errors when configuration can't be loaded * Use ErrorMessage in PagedList * Add icon to error message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a nasty but unlikely bug where if the configuration query fails for any reason, then the UI configuration will be clobbered by the front page initialisation.
This also revamps the
ErrorMessagecomponent to present more like a typical error message:TODO: test these with longer error messages