Partial fix for #2761 - Add reverse proxy prefix to HLS links#5791
Merged
WithoutPants merged 2 commits intostashapp:developfrom Apr 2, 2025
Merged
Partial fix for #2761 - Add reverse proxy prefix to HLS links#5791WithoutPants merged 2 commits intostashapp:developfrom
WithoutPants merged 2 commits intostashapp:developfrom
Conversation
WithoutPants
reviewed
Apr 2, 2025
pkg/ffmpeg/stream_segmented.go
Outdated
| return | ||
| } | ||
|
|
||
| prefix := strings.TrimRight(r.Header.Get("X-Forwarded-Prefix"), "") |
Collaborator
There was a problem hiding this comment.
strings.TrimRight with "" is a no-op, so I'm not sure why this is here.
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Oct 22, 2025
…stashapp#5791) * Partial fix for stashapp#2761 - Add reverse proxy prefix to HLS links --------- Co-authored-by: Guido <[email protected]> Co-authored-by: WithoutPants <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds prefix from X-Forwarded-Prefix to links generated in HLS file. Partial fix for issue #2761