Skip to content

Comments

Display tag and performer image on hover. on the scene edit page#5739

Merged
WithoutPants merged 6 commits intostashapp:developfrom
blaspheme-ship-it:display-tag-image-on-hover-scene-edit
Apr 2, 2025
Merged

Display tag and performer image on hover. on the scene edit page#5739
WithoutPants merged 6 commits intostashapp:developfrom
blaspheme-ship-it:display-tag-image-on-hover-scene-edit

Conversation

@blaspheme-ship-it
Copy link
Contributor

@blaspheme-ship-it blaspheme-ship-it commented Mar 19, 2025

closes #4320

  • adds component to display a performer pop over copied from the TagPopoverComponent and wraps the select label and options in it.
  • Also raps tag label in the currently existing TagPopoverComponent.

@WithoutPants WithoutPants added this to the Version 0.29.0 milestone Mar 20, 2025
@WithoutPants WithoutPants added the improvement Something needed tweaking. label Apr 2, 2025
@WithoutPants
Copy link
Collaborator

I reverted the change to show the hover popover when mousing over options in the drop down. I personally find the hover popover behaviour for tags highly irritating. I tried making the popover only occur when mousing over the performer image, but it still had issues overflowing the window. To me it seems unnecessary: most relevant information is available in the option already, and you can navigate to the performer page by clicking on the performer image (which you can't currently do for tags). In any case, I don't want that to prevent merging in the rest of it, so feel free to submit that part as a separate PR for discussion if you wish.

It's not ideal that the popover components make a graphql request for the tag/performer object, when we have the objects available in the select control. I tried changing the popover components to accept an object, but it appears at least for tags, the returned data object is missing information, which caused a UI crash when hovering. I've left it as is for now.

@WithoutPants WithoutPants merged commit 3489dca into stashapp:develop Apr 2, 2025
2 checks passed
XGFan pushed a commit to XGFan/stash that referenced this pull request Oct 22, 2025
…shapp#5739)

* add component for PerformerPopover
* show PerformerPopover for performer select values
* show TagPopover for tag select values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Something needed tweaking.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Display Tag Image/Performer Image on hover, after they are selected on the Edit page

2 participants