Fix various migration issues#5723
Merged
WithoutPants merged 7 commits intostashapp:developfrom Mar 18, 2025
Merged
Conversation
In most cases is probably not needed and can be an optonal user-initiated step
This reverts commit 3b01905.
Flush WAL file at end of migration
feederbox826
approved these changes
Mar 18, 2025
Collaborator
feederbox826
left a comment
feederbox826
left a comment
There was a problem hiding this comment.
feederbox approved
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Indicate while backing up database * Close migrate connection to db before optimising * Don't vacuum post-migration In most cases is probably not needed and can be an optonal user-initiated step * Ensure connection close on NewMigrator error * Perform post-migration using migrator connection Flush WAL file at end of migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @cj12312021 for the massive database to test the migration process against. Resolves the following issues found while testing:
database lockedand database corruption issues that were encounteredwhen running a vacuum, the wal file is now flushed so that we're not left with a wal file the size of the whole database file