Use tag exclusions when identifying scenes#5686
Merged
WithoutPants merged 3 commits intostashapp:developfrom Feb 26, 2025
Merged
Use tag exclusions when identifying scenes#5686WithoutPants merged 3 commits intostashapp:developfrom
WithoutPants merged 3 commits intostashapp:developfrom
Conversation
WithoutPants
added
bug
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Move tag exclusion code back into scraper package Reverts stashapp#2391 * Rearrange stash box client code * Filter excluded tags in stashbox queries Re-application of fix for stashapp#2379
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts #2391 - which moved the tag exclusion behaviour from the
scraperpackage into theapipackage. Being business logic, it does not belong in the interface code.This meant re-implementing the fix for #2379 by adding exclusion logic into the stash-box code. Once this was done, the identify functionality could use the exclusion behaviour without much further work.
While I was in the
stashboxpackage, I rearranged it into separate files, rather than one giant one.Fixes #5564