Fix scraping multiple URLs #5677
Merged
WithoutPants merged 4 commits intostashapp:developfrom Feb 25, 2025
Merged
Conversation
Collaborator
|
Tested with several existing community scrapers (IAFD, The Nude, Babepedia, MFC) and some custom scrapers. Everything looks to work in my testing so far. If |
feederbox826
added a commit
to stashapp/CommunityScrapers
that referenced
this pull request
Feb 26, 2025
This was referenced Mar 24, 2025
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Hack fix for scraping URLs field * Rewrite apply function using known value types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mapped scraper functionality is in sore need of a rework. #5294 has highlighted this with the new
URLsfield. For now, I've hacked in a solution that should correctly convert URLs to a list.Notably, this does not work where
URLsis used in a sub-object scenario. For example, it will populate only a single URL in theURLsfield of performers within a scene scrape. This is because there is currently no way to determine which performer a given URL value belongs to. Therefore, it follows existing convention and assigns one URL for each performer result. This means that it is not possible to have multiple URLs for any performer within a scene scrape.Resolves #5294
For testing, I used the following performer scraper for LinkTree: