Custom fields filter UI#5632
Merged
WithoutPants merged 6 commits intostashapp:developfrom Feb 24, 2025
Merged
Conversation
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Refactor criteria and criterion options * Add custom fields filtering in UI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Custom Fieldsentry to the Performer filter criteria list, allowing to filter on custom field values.Initial view:
Once the field value is entered, the confirm button becomes enabled, allowing to add the criterion.
Current criteria is show below the input fields as filter tags. Clicking on the filter tag allows editing the criterion:
Clicking on the x button cancels the edit and clears the input fields. A pencil icon indicates the currently edited criterion.
Custom field criteria is shown as follows in the list pages:
Clicking on the tag only opens the edit filter dialog selecting the custom fields criteria but does not select that specific field.