Fix Handy script not playing after revisiting scene#5578
Merged
WithoutPants merged 1 commit intostashapp:developfrom Jan 30, 2025
Merged
Fix Handy script not playing after revisiting scene#5578WithoutPants merged 1 commit intostashapp:developfrom
WithoutPants merged 1 commit intostashapp:developfrom
Conversation
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5577
The problem seems to be that the hook for player initialization is executed after the hook for script uploading.
interactiveReadyis first set to true by the script uploading hook (correct), but then gets reset to false by the player initialization hook (incorrect).I think it's safe to delete the line I deleted since it should get set to false by the script uploading hook anyway, but I'm rather new to React, so please correct me if I'm wrong. There might even be a better way of solving this, like somehow ensuring the script uploading hook gets executed after the player initialization hook.
I tested the change locally. It fixed the problem and everything else seemed fine.