Handy integration improvements#5576
Merged
WithoutPants merged 10 commits intostashapp:developfrom Feb 28, 2025
Merged
Conversation
dumdum7
changed the title
Eliminates redundant API calls by only relying on playing and pause events. Handles edge cases for playback before script upload completion.
We don't need it anymore, listening for playing and pause events is enough.
…ty tracker dependency change
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* Use playing event instead of play * Remove unnecessary ensurePlaying() from timeupdate listener Eliminates redundant API calls by only relying on playing and pause events. Handles edge cases for playback before script upload completion. * Remove unnecessary video seeking event listener We don't need it anymore, listening for playing and pause events is enough. * Send second play event after a play event to adjust for video player issues * Fix script being paused and played after 10 seconds because of activity tracker dependency change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't have much experience with React, so if there are better ways of doing things in React I would greatly appreciate any feedback.