Add Sort Name to Tags#5531
Merged
WithoutPants merged 12 commits intostashapp:developfrom Feb 10, 2025
Merged
Conversation
this could go nowhere, testing things out
override "name" sort with COALESCE
adds `data-sort-name` attribute to tag links prioritizes sort_name value but will default to tag name if not present in the same way that COALESCE will prioritize the same values in the same way
Collaborator
|
Lightly tested, no more issues found. |
WithoutPants
approved these changes
Feb 10, 2025
Collaborator
WithoutPants
left a comment
WithoutPants
left a comment
There was a problem hiding this comment.
Thanks! This looks good. I made the following changes:
- Changed the display name to be
Sort Nameinstead ofSorting Name - Added new field to anonymiser
- Added new field to import/export
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Mar 27, 2025
* override "name" sort with COALESCE * tag sort_name frontend adds `data-sort-name` attribute to tag links prioritizes sort_name value but will default to tag name if not present in the same way that COALESCE will prioritize the same values in the same way * add sort_name filter, update locale per request * Include sort name in anonymiser * Add import/export support --------- Co-authored-by: WithoutPants <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a sort name to tags
Resolves #3108