Convert json numbers to numbers in JSON inputs#5496
Merged
WithoutPants merged 1 commit intostashapp:developfrom Nov 21, 2024
Merged
Convert json numbers to numbers in JSON inputs#5496WithoutPants merged 1 commit intostashapp:developfrom
WithoutPants merged 1 commit intostashapp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric values when provided to the server via the graphql interface, end up encoded
json.Numberif they do not have a specific schema type - for example, when passed in via a generic map. This means that the UI and plugin settings would save numeric values as strings. This caused an issue with the Image Wall margins, since it expected a numeric value and not a string value. This could also cause additional intended consequences.This change converts
json.Numbervalues in map values to the correctint64orfloat64values.Fixes #5483. Note that this will require re-saving the image margin value to fix the issue.