Scene Marker duration filter and sort#5472
Merged
WithoutPants merged 7 commits intostashapp:developfrom Nov 29, 2024
Merged
Conversation
Collaborator
|
Thanks for this. I changed the filter type to be a nullable float filter, since imo a marker without an end point should have a null duration, rather than a duration of 0. The other duration filter fields should probably be changed to be floats as well, but that's a problem for a separate PR. |
XGFan
pushed a commit
to XGFan/stash
that referenced
this pull request
Jan 16, 2025
Co-authored-by: WithoutPants <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to sort and filter Markers by their duration (the difference between
secondsandend_seconds). Markers without an end point have zero duration so a 0:00 duration filter can be used to filter for them.