Sub second marker timestamp precision#5431
Merged
WithoutPants merged 7 commits intostashapp:developfrom Nov 2, 2024
Merged
Conversation
Collaborator
|
I personally don't prefer frames in SMPTE, I much prefer
If you do want to stick to SMPTE, then I suggest sticking with HH:MM:SS:FFFF to not confuse it with .ms |
Contributor
|
I also think that more users would be familiar with millisecond times over a frame number. And not exactly relevant, but just as another data point for reference: Android media3's ExoPlayer uses a millisecond precision 64 bit integer for timestamps when playing video files. |
Collaborator
Author
|
Thanks for the feedback. I've updated to use |
Eliminates the need to include frameRate
WithoutPants
force-pushed
the
sub-second-timestamp
branch
from
8cde73f to
af780cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #5382
Allows specifying marker times by frame within seconds:
Frames are specified with a trailing
.ffffwhich is the 0-based frame number.Times with a fractional component are formatted as
[hh:]mm:ss.ffff- frame number 12 at time3:45is displayed as3:45:0012. The time field accepts the same value without the leading zeroes as well, ie3:45.12, but will be re-formatted to the other format.Times at frame 0 are accepted and displayed without the
.ffffsuffix.Times from the current frame of the video will include sub-second precision.
The length of the
fffffield was an arbitrary choice and I'm happy to hear alternatives.This PR will be rebased once #5311 is merged.