Move modifiers into selectable options in object filter selectors#5203
Merged
WithoutPants merged 2 commits intostashapp:developfrom Oct 29, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the modifier buttons from the Performer, Studio and Tags criterion editors in favour of selectable items that are (imo) more intuitive and use more user-friendly language:

AnyandNoneare the equivalent ofnot nullandis nullrespectively, and only show if nothing else is selected. If either of these are selected, then no other options are shown:If one or more objects are selected, the
Any ofandOnlyoptions are made available.Any ofis the equivalent ofincludes(instead ofincludes all), andonlyis the equivalent ofequals.These special items are shown in parentheses, italics and with a lower opacity to distinguish them from regular items.
Given that it's a single value field, the studio selector does not have the
Any oforOnlyoptions.