fix(jobs): Handle zero jobs with zero thresholds #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
As mentioned here #2610 (comment) instead of allowing a negative threshold, allow setting zero as a threshold. |
vladimyr
reviewed
Apr 20, 2021
andytom
changed the title
vladimyr
changed the title
vladimyr
approved these changes
Apr 20, 2021
Member
vladimyr
left a comment
vladimyr
left a comment
There was a problem hiding this comment.
First PR here, let me know if anything can be improved!
Sure, do more great PRs like this one! ❤️
LGTM
Member
|
Actually, I forgot, docs need to get updated too 🙃 |
Contributor
Author
Thank you for the reviews!! And I just added the docs, lmk if it sounds good or if I should change the wording |
Member
frezbo
added a commit
to frezbo/ansible-workstation
that referenced
this pull request
Apr 22, 2021
DavidSmith166
pushed a commit
to DavidSmith166/starship
that referenced
this pull request
Apr 24, 2021
* Handle zero jobs with negative thresholds * Allow for zero threshold only * Log when threshold is less than zero * Address comments * Add docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR here, let me know if anything can be improved!
Description
Currently, if there are 0 jobs running then the jobs module doesn't show anything. However, if a negative threshold is specified (user wants to explicitly see that there are 0 jobs running), then it should show 0.
Closes #2610
How Has This Been Tested?
Checklist: