Skip to content

Cleanups and HIP bugfix#16

Merged
stanmoore1 merged 5 commits intostanmoore1:kk_update_4.0from
rbberger:kk_cpp17_update
Apr 24, 2023
Merged

Cleanups and HIP bugfix#16
stanmoore1 merged 5 commits intostanmoore1:kk_update_4.0from
rbberger:kk_cpp17_update

Conversation

@rbberger
Copy link
Copy Markdown

Summary

  • various cleanups that are now possible due to requiring C++17
  • Bugfix for HIP, since it no longer is in the Kokkos::Experimental namespace.

Related Issue(s)

Author(s)

@rbberger

Licensing

By submitting this pull request, I agree, that my contribution will be included in LAMMPS and redistributed under either the GNU General Public License version 2 (GPL v2) or the GNU Lesser General Public License version 2.1 (LGPL v2.1).

Backward Compatibility

Implementation Notes

Post Submission Checklist

  • The feature or features in this pull request is complete
  • Licensing information is complete
  • Corresponding author information is complete
  • The source code follows the LAMMPS formatting guidelines
  • Suitable new documentation files and/or updates to the existing docs are included
  • The added/updated documentation is integrated and tested with the documentation build system
  • The feature has been verified to work with the conventional build system
  • The feature has been verified to work with the CMake based build system
  • Suitable tests have been added to the unittest tree.
  • A package specific README file has been included or updated
  • One or more example input decks are included

Further Information, Files, and Links

Copy link
Copy Markdown
Owner

@stanmoore1 stanmoore1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @rbberger!

@stanmoore1 stanmoore1 merged commit 8a118b6 into stanmoore1:kk_update_4.0 Apr 24, 2023
@rbberger rbberger deleted the kk_cpp17_update branch April 24, 2023 21:12
stanmoore1 pushed a commit that referenced this pull request Jun 24, 2024
stanmoore1 pushed a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants