Repository navigation
test: skip alias-collision test when symlink creation is unavailable - #10410
isaacbmiller merged 1 commit into
Conversation
alias.symlink_to() raises OSError (WinError 1314) on unprivileged Windows, erroring this test in setup. Mirror the guard already used at test_symlinked_path_resolution in the same file. Co-Authored-By: Claude Opus 4.8 <[email protected]>
|
|
tests/primitives/test_python_interpreter.py::test_rejects_alias_basename_colliding_with_another_file calls alias.symlink_to(first) unconditionally, which raises OSError (WinError 1314) on unprivileged Windows (no elevation, Developer Mode off) and errors the test in setup. The same file already guards the identical call in test_symlinked_path_resolution (the try/except (OSError, NotImplementedError) → pytest.skip block). This applies that existing pattern to the one spot that was missing it. Behaviour is unchanged wherever symlinks are available. (Reviewed line-by-line; AI-assisted — the commit carries a Co-Authored-By trailer.) The diff (already committed on the branch):
|
|
lgtm. Thanks for the pr! |
tests/primitives/test_python_interpreter.py::test_rejects_alias_basename_colliding_with_another_file calls alias.symlink_to(first) unconditionally, which raises OSError (WinError 1314) on unprivileged Windows (no elevation, Developer Mode off) and errors the test in setup.
The same file already guards the identical call in test_symlinked_path_resolution (the try/except (OSError, NotImplementedError) → pytest.skip block). This applies that existing pattern to the one spot that was missing it.
Behaviour is unchanged wherever symlinks are available.
(Reviewed line-by-line; AI-assisted — the commit carries a Co-Authored-By trailer.)
The diff (already committed on the branch):