Add optims to detect when SoA matrices can be used#955
Add optims to detect when SoA matrices can be used#955SteveBronder merged 96 commits intostan-dev:masterfrom
Conversation
…tions expressions of a UDF
|
The tests are now failing with: |
|
Oh whoops yes lkj is not supported by the new matrix type yet |
|
@rybern alright I think this is good to go! I currently have things set to have this turned on by default at Does that work for you? |
|
I like the idea of this / #1029 to be on in O1, but make O1 the default after the next release. I think O0 staying as a 'do absolutely nothing' option is valuable |
|
That scheme sounds good to me @SteveBronder. +1 for @WardBrian's comment about keeping The last thing I want to double check on is https://github.com/stan-dev/stanc3/pull/955/files#r713252249, because that'd potentially give correctness issues |
|
Alrighty @rybern I just added the above tests, if everything compiles correctly on Jenkins then I'm going to remove soa from |
…d values in assignments
|
D-O-N-E!!! |
|
Thanks all for sticking through this! The |
|
WHOW!!! Can I use it now? How?? I wanna test!! Seriously... is there a simple way to make a test drive with my favourite model? Just do -O1 as argument to the parser and that's it? I am really looking forward to this! |
|
Just O1 should do it! |
Ignore for now, I'm debugging a few things and will ping @rybern and @rok-cesnovar when this is ready for review / will fill out the top level comment describing the scheme and changes here.
Submission Checklist
Release notes
Allows
log_prob_implto use Struct of Arrays type for reverse mode autodiffCopyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)