Remove deprecated use of 'jacobian' as non-keyword#1573
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1573 +/- ##
==========================================
- Coverage 90.31% 90.30% -0.01%
==========================================
Files 65 65
Lines 10057 10050 -7
==========================================
- Hits 9083 9076 -7
Misses 974 974
🚀 New features to boost your workflow:
|
nhuurre
reviewed
Dec 9, 2025
| @@ -1,17 +1,12 @@ | |||
| functions { | |||
| real jacobian(real x, int y) { | |||
| real foo_jacobian(real x, int y) { | |||
Collaborator
There was a problem hiding this comment.
So jacobian as an identifier is removed now but _jacobian as a function suffix stays for one more release.
And we didn't have a test for function suffix deprecation?
Member
Author
There was a problem hiding this comment.
Correct, because we marked jacobian as reserved a version earlier while we were still designing the feature, so the _jacobian function idea hadn't come about yet.
nhuurre
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Release notes
Expiring deprecation:
jacobianis now a reserved keyword.Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)