Include locations in all pedantic warnings#1568
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1568 +/- ##
=========================================
Coverage ? 90.27%
=========================================
Files ? 65
Lines ? 9997
Branches ? 0
=========================================
Hits ? 9025
Misses ? 972
Partials ? 0
🚀 New features to boost your workflow:
|
nhuurre
left a comment
nhuurre
left a comment
There was a problem hiding this comment.
You write "when the exact location of a warning is not clear" but in my opinion these warnings do have pretty clear locations; it's always the location of the relevant parameter declaration.
Make Mir_utils.parameter_set return the location spans in addition to the names and that should fix the warnings about unused parameters and hard constraints.
The warning about multiple priors (or "non-one prior" as the code calls it...) may be a bit trickier.
|
That's a good point. Even the more than one prior warning can reasonably just point to the line of the parameter being declared and call it a day |
WardBrian
changed the title
2 participants
Submission Checklist
Release notes
All warnings from pedantic mode will now have a location associated with them.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)