Begin cleaning up semantic errors, establishing styling conventions#1561
Merged
Begin cleaning up semantic errors, establishing styling conventions#1561
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1561 +/- ##
==========================================
+ Coverage 90.26% 90.27% +0.01%
==========================================
Files 64 65 +1
Lines 9929 9981 +52
==========================================
+ Hits 8962 9010 +48
- Misses 967 971 +4
🚀 New features to boost your workflow:
|
nhuurre
reviewed
Oct 14, 2025
WardBrian
force-pushed
the
semantic-error-coloring
branch
from
8c08ccd to
7ff4ac2
Compare
Member
Author
|
(note, Nonempty_list will be in the next Core version, c.f. janestreet/core#177 janestreet/core_kernel@4b48de7) |
nhuurre
approved these changes
Oct 14, 2025
Nonempty_list will be in the next Core version, c.f. janestreet/core#177 janestreet/core_kernel@4b48de7
WardBrian
force-pushed
the
semantic-error-coloring
branch
from
dc518b1 to
1051c99
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #1551, this tries to set up some conventions for semantic errors by defining and using some consistent helper functions for things like "Found one type but expected another", or for quoting a string, etc.
Submission Checklist
Release notes
Type errors will now contain colors.
Copyright and Licensing
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)